From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: hdmi: Open-code drm_simple_encoder_init() Date: Sat, 16 May 2026 12:11:37 +1000 Message-ID: In-Reply-To: <20260502143420.7850-1-souradiptodas6@gmail.com> References: <20260502143420.7850-1-souradiptodas6@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/tegra: hdmi: Open-code drm_simple_encoder_init() Author: Souradipto Das Patches: 2 Reviewed: 2026-05-16T12:11:37.822669 --- This mbox contains two versions of the same patch =E2=80=94 v1 and v2 =E2= =80=94 by Souradipto Das, which open-codes `drm_simple_encoder_init()` in t= he tegra HDMI driver. The change is straightforward and mechanically correc= t: it replaces a call to a trivial helper with the underlying `drm_encoder_= init()` call and a driver-local `drm_encoder_funcs` struct, removing the de= pendency on `drm_simple_kms_helper.h`. This is part of a broader cleanup ef= fort suggested by Thomas Zimmermann. The v2 patch fixes the stray blank line from v1. One minor style issue rema= ins (missing blank line before the new struct), and the unchecked return va= lue of `drm_encoder_init()` is carried over from the original code. The oth= er tegra encoder drivers (rgb, dsi, sor) still use `drm_simple_encoder_init= ()` and have the same unchecked-return pattern, so this patch is consistent= with the rest of the driver. **Verdict:** The v2 patch is correct and suitable for merge, with one minor= style nit. --- Generated by Claude Code Patch Reviewer