From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915: replace select with dependency for visible DEBUG_OBJECTS Date: Tue, 05 May 2026 08:46:43 +1000 Message-ID: In-Reply-To: <20260502191932.4491-1-julianbraha@gmail.com> References: <20260502191932.4491-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915: replace select with dependency for visible DEBUG_OBJECTS Author: Julian Braha Patches: 1 Reviewed: 2026-05-05T08:46:43.221055 --- This is a single-patch series changing `DRM_I915_SW_FENCE_DEBUG_OBJECTS` fr= om `select DEBUG_OBJECTS` to `depends on DEBUG_OBJECTS`. The stated rationa= le is that `select` should not be used on user-visible symbols. While that = Kconfig convention is real, this patch has a **functional regression** that= makes it unsuitable for merging as-is: `DRM_I915_DEBUG` uses `select DRM_I= 915_SW_FENCE_DEBUG_OBJECTS` (line 62 of `Kconfig.debug`), and after this ch= ange, that `select` will silently fail whenever `DEBUG_OBJECTS` is not alre= ady enabled =E2=80=94 breaking the intended behavior of the umbrella `DRM_I= 915_DEBUG` option. **Verdict: Needs rework.** --- --- Generated by Claude Code Patch Reviewer