From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds Date: Tue, 05 May 2026 08:45:16 +1000 Message-ID: In-Reply-To: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn> References: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disabl= e cmds Author: Icenowy Zheng Patches: 2 Reviewed: 2026-05-05T08:45:16.029688 --- This is a single-patch fix for the `panel-boe-tv101wum-nl6` driver. The pro= blem is real and well-understood: `boe_panel_disable()` clears `MIPI_DSI_MO= DE_LPM` so that the display-off and enter-sleep-mode commands are sent in H= S mode, but it never restores the flag. On the next enable/prepare cycle, t= he init commands are sent without LPM set on `dsi->mode_flags`, which cause= s errors because the panel expects LP mode for initialization commands. The fix is correct in principle =E2=80=94 other panel drivers (e.g., `panel= -boe-bf060y8m-aj0`, `panel-boe-td4320`, `panel-himax-hx83112b`) follow the = same pattern of clearing LPM for disable commands and restoring it afterwar= d. **Verdict: The fix addresses a real bug and should be accepted, with one pl= acement concern worth discussing.** --- Generated by Claude Code Patch Reviewer