From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add support for suppressing warning backtraces Date: Tue, 05 May 2026 08:33:31 +1000 Message-ID: In-Reply-To: <20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com> References: <20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: kunit: Add support for suppressing warning backtraces Author: Albert Esteve Patches: 6 Reviewed: 2026-05-05T08:33:31.036374 --- This v8 series adds a KUnit API for suppressing WARN*() backtraces during unit tests, a well-motivated feature that has been through extensive iteration. The design is sound: task-scoped suppression integrated into the existing KUnit hooks mechanism with zero overhead when tests aren't running (via the `kunit_running` static key). The three API forms (scoped, manual macros, direct functions) cover the right use cases. The implementation is solid overall. RCU-protected reader path with spinlock-protected writer side is the correct approach. The placement of suppression checks at three points in the warning path (warn_slowpath_fmt, __warn_printk, __report_bug) is well-considered, and the `count` parameter to avoid double-counting is a nice detail. The test coverage is thorough, including cross-kthread isolation. I have a few concerns, mostly minor, detailed below. --- Generated by Claude Code Patch Reviewer