From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: panel: support the R63419 based dual-DSI video mode Display Panels Date: Tue, 05 May 2026 08:29:49 +1000 Message-ID: In-Reply-To: <20260504-topic-sm8650-ayaneo-pocket-s2-r63419-v3-0-9f61cf24aebf@linaro.org> References: <20260504-topic-sm8650-ayaneo-pocket-s2-r63419-v3-0-9f61cf24aebf@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: panel: support the R63419 based dual-DSI video mode Display P= anels Author: Neil Armstrong Patches: 3 Reviewed: 2026-05-05T08:29:49.895264 --- This is a 2-patch series by Neil Armstrong (with driver code from KancyJoe)= adding support for Renesas R63419-based dual-DSI video mode panels found i= n Ayaneo handheld gaming devices. The series consists of a DT binding (patc= h 1) and a panel driver (patch 2). The overall structure is clean and follows modern panel driver conventions = (uses `devm_drm_panel_alloc`, `mipi_dsi_multi_context`, `devm_regulator_bul= k_get_const`, etc.). However, there are a few issues worth addressing: **Key issues:** 1. The DSI init sequence sends display-on *before* exit-sleep-mode, which i= s reversed from the standard MIPI DCS order and from what other panel drive= rs do. 2. The dual-DSI error handling uses two separate `mipi_dsi_multi_context` s= tructs but only checks `accum_err` from the first one =E2=80=94 errors on t= he second DSI link are silently lost. The existing `mipi_dsi_dual()` macro = solves this correctly. 3. The panel descriptors should be `const`. 4. The DT binding example has vsp/vsn supply names that appear swapped. --- --- Generated by Claude Code Patch Reviewer