From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: i.MX LDB DT cleanups Date: Tue, 05 May 2026 07:44:14 +1000 Message-ID: In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de> References: <20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: i.MX LDB DT cleanups Author: Marco Felsch Patches: 5 Reviewed: 2026-05-05T07:44:14.436314 --- This is a clean 4-patch series that removes the unused `reg` and `reg-names= ` device tree properties from the fsl,ldb (LVDS Display Bridge) binding and= associated DTS files. The rationale is sound: the LDB driver (`drivers/gpu= /drm/bridge/fsl-ldb.c`) has **never** used these properties. It obtains reg= ister access via `syscon_node_to_regmap(dev->of_node->parent)` and uses har= dcoded offsets from per-device-type driver data. The parent syscon nodes (I= OMUX_GPR, BLK_CTRL) have multi-purpose registers shared across sub-devices,= making per-sub-device `reg` properties semantically incorrect. The ordering is correct: revert the binding schema additions first (patches= 1-2), then remove the properties from the DTS files (patches 3-4). The fin= al binding YAML and DTS files are consistent and well-formed. The cover letter honestly notes "I didn't do runtime tests" =E2=80=94 this = is acceptable given the driver provably ignores these properties, so there = is no functional change. **Verdict: Series looks good. No blocking issues.** --- --- Generated by Claude Code Patch Reviewer