From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: vop2: Fix layer cfg done timeout on multi-output setups Date: Tue, 05 May 2026 08:08:45 +1000 Message-ID: In-Reply-To: <20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com> References: <20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/rockchip: vop2: Fix layer cfg done timeout on multi-output set= ups Author: Cristian Ciocaltea Patches: 6 Reviewed: 2026-05-05T08:08:45.269819 --- This is a well-structured 5-patch series fixing a real race condition in th= e VOP2 overlay layer configuration path on RK3568/RK3588 multi-output setup= s. The cover letter clearly explains the two root causes (patches 1 and 2) = and separates the cleanups (patches 3-5). The two bug fixes are correct: patch 1 fixes passing an already-clobbered v= alue as the wait target, and patch 2 reorders operations so the previous VP= 's vsync can still latch the pending configuration before LAYERSEL_REGDONE_= SEL is switched. The cleanup patches are straightforward and low-risk. One concern worth raising is the interaction between patches 3 and 5 and th= e `readx_poll_timeout_atomic` spin in `rk3568_vop2_wait_for_layer_cfg_done(= )` =E2=80=94 see patch 5 comments below. **Recommendation: Patches 1 and 2 look good for merge (with Fixes tags for = stable). Patches 3-5 are clean and correct but patch 5 has a minor concern = worth discussing.** --- --- Generated by Claude Code Patch Reviewer