public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm/pool: back up at native page order
Date: Tue, 05 May 2026 08:38:59 +1000	[thread overview]
Message-ID: <review-overall-20260504042619.2896273-1-matthew.brost@intel.com> (raw)
In-Reply-To: <20260504042619.2896273-1-matthew.brost@intel.com>

Overall Series Review

Subject: drm/ttm/pool: back up at native page order
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 5
Reviewed: 2026-05-05T08:38:59.897610

---

This is a single patch that modifies TTM pool backup to preserve compound page integrity during the shrinker backup path, avoiding memory fragmentation caused by unconditionally splitting higher-order allocations to order-0 before writing to shmem. The motivation is sound and well-documented: under kswapd pressure, the existing `split_page()` approach shatters higher-order blocks, amplifying fragmentation and preventing the system from recovering.

The core approach — back up each sub-page to shmem but free the allocation atomically at native order — is clean. The rollback logic for partial failures is correct and ensures compound-level atomicity. However, there is one significant issue: the patch uses `__free_pages_gpu_account()`, which does not exist in the current drm-next tree. This is an unstated build dependency on another pending series (likely [1] referenced in the cover notes). The patch cannot compile standalone against drm-next.

The commit message is thorough, and the `Cc: stable` tag is present, but the stable backport would also need the dependency or an adaptation.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 22:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  4:26 [PATCH] drm/ttm/pool: back up at native page order Matthew Brost
2026-05-04  8:35 ` Thomas Hellström
2026-05-04 14:30   ` Matthew Brost
2026-05-04 15:19     ` Thomas Hellström
2026-05-04 17:35       ` Matthew Brost
2026-05-04 22:38 ` Claude Code Review Bot [this message]
2026-05-04 22:39 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260504042619.2896273-1-matthew.brost@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox