From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu/buddy: Per-order free and used block scoreboards Date: Tue, 05 May 2026 08:19:36 +1000 Message-ID: In-Reply-To: <20260504135343.1797869-1-francois.dugast@intel.com> References: <20260504135343.1797869-1-francois.dugast@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu/buddy: Per-order free and used block scoreboards Author: Francois Dugast Patches: 3 Reviewed: 2026-05-05T08:19:36.860161 --- This is a clean, well-motivated 2-patch series that replaces O(n) rbtree walks in `drm_buddy_print()` / `gpu_buddy_print()` with O(1) scoreboard array lookups. The approach is sound: maintain per-order counters at the points where block state transitions happen, removing the need to traverse the free trees at debugfs read time. The free scoreboard (patch 1) is correctly maintained at all five state-transition sites. The init/fini and error-handling paths are properly updated. The series is low-risk and the resulting print functions are much simpler. However, the used scoreboard (patch 2) has a correctness issue in the coalescing loop, and there are a couple of naming/style nits worth noting. --- --- Generated by Claude Code Patch Reviewer