From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Consistently define pci_device_ids using named initializers Date: Tue, 05 May 2026 08:10:52 +1000 Message-ID: In-Reply-To: <20260504150537.2136760-2-u.kleine-koenig@baylibre.com> References: <20260504150537.2136760-2-u.kleine-koenig@baylibre.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: Consistently define pci_device_ids using named initializers Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= Patches: 1 Reviewed: 2026-05-05T08:10:52.264043 --- This is a single-patch cleanup that converts four DRM drivers' `pci_device_id` tables from positional initializers to named initializers using the `PCI_DEVICE` / `PCI_VDEVICE` macros and `.driver_data =` syntax. The change is purely mechanical and well-motivated: it improves readability and prepares for a future change to make `driver_data` an anonymous union (which requires named initializers). The author states binary equivalence was verified on x86 and arm64, which is the right level of testing for this kind of change. **Recommendation: This patch looks correct and ready to merge.** One minor nit below on the qxl conversion. --- Generated by Claude Code Patch Reviewer