From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc/tegra: pmc: Clean up legacy code Date: Thu, 07 May 2026 13:29:33 +1000 Message-ID: In-Reply-To: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> References: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: soc/tegra: pmc: Clean up legacy code Author: Thierry Reding Patches: 11 Reviewed: 2026-05-07T13:29:33.658765 --- This is a well-structured 9-patch series from Thierry Reding that migrates Tegra PMC consumers away from legacy global-state APIs (`tegra_powergate_*`, `tegra_io_pad_*`) to new instance-aware APIs (`tegra_pmc_powergate_*`, `tegra_pmc_io_pad_*`) that take an explicit `struct tegra_pmc *`. The motivation is sound: future SoCs can have multiple PMC instances, and the global variable approach cannot support that. The series follows a clean pattern: patches 1-6 convert each consumer subsystem, patch 7 reworks the PMC driver internals to allocate context dynamically, patch 8 removes the now-unused legacy wrappers, and patch 9 gates the remaining legacy code behind `CONFIG_ARM`. The conversion patches are largely mechanical and consistent. However, there is **one real bug** in patch 5 (PCI) and a few minor style/correctness observations throughout. Overall the series is in good shape and the approach is correct. The one bug needs fixing before merge. --- --- Generated by Claude Code Patch Reviewer