Claude review: drm/bridge: imx8qxp-pxl2dpi: avoid ERR_PTR with device_node cleanup

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/bridge: imx8qxp-pxl2dpi: avoid ERR_PTR with device_node cleanup
Author: Guangshuo Li <lgs201920130244@gmail.com>
Patches: 2
Reviewed: 2026-05-07T13:23:41.500001

---

This is a single-patch bug fix for a real and valid problem. The `__free(device_node)` cleanup attribute calls `of_node_put()` on any non-NULL pointer, but `imx8qxp_pxl2dpi_get_available_ep_from_port()` returns `ERR_PTR()` values on error. When `imx8qxp_pxl2dpi_find_next_bridge()` stores such an `ERR_PTR()` in a `__free(device_node)` variable and then returns, the cleanup will call `of_node_put()` on the error pointer — corrupting memory or causing a crash.

The fix is correct and well-designed: change the helper to return `int` and pass the endpoint node via an output parameter initialized to `NULL`. This ensures the cleanup variable only ever holds `NULL` or a valid `device_node` pointer.

The patch is at v6 and has clearly been through careful review iteration. The approach is sound and the implementation is clean.

**Verdict: This patch looks good and should be accepted.**

---
Generated by Claude Code Patch Reviewer