From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: add hardware cursor support Date: Thu, 07 May 2026 13:14:48 +1000 Message-ID: In-Reply-To: <20260506175610.2542888-1-zhengxingda@iscas.ac.cn> References: <20260506175610.2542888-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: verisilicon: add hardware cursor support Author: Icenowy Zheng Patches: 3 Reviewed: 2026-05-07T13:14:48.302369 --- This is a well-structured 2-patch series adding hardware cursor support to the Verisilicon display controller driver. Patch 1 adds the HWDB plumbing, patch 2 implements the cursor plane. The approach is sound and the series shows good v3 iteration improvements (simpler validation, proper modifier list, visibility-based check skipping). However, **patch 2 has a critical bug**: the negative-coordinate offset values are never shifted into their register field positions, so partially-offscreen cursors will not work correctly. There is also an off-by-one error in the coordinate range checks, minor typos in register defines, and a missing `cursor_width`/`cursor_height` setting in mode_config. --- Generated by Claude Code Patch Reviewer