From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: iris: migrate to using global UBWC config Date: Thu, 07 May 2026 12:40:16 +1000 Message-ID: In-Reply-To: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: media: iris: migrate to using global UBWC config Author: Dmitry Baryshkov Patches: 8 Reviewed: 2026-05-07T12:40:16.438595 --- This is a clean, well-structured 7-patch series that migrates the Qualcomm Iris video decoder driver from maintaining its own UBWC (Universal Bandwidth Compression) configuration to using the centralized `QCOM_UBWC_CONFIG` registry. The motivation is sound: duplicating UBWC parameters (HBB, swizzle, bank spreading, etc.) per-driver is error-prone, especially since values like `highest_bank_bit` can depend on DDR type at runtime rather than being fixed constants. The series is incrementally decomposed -- each patch replaces one parameter, which makes bisection and review straightforward. All patches carry Reviewed-by from Konrad Dybcio, Bryan O'Donoghue, and Dikshita Agarwal, plus a Tested-by from Wangao Wang. The cover letter notes this is compile-tested only by the author due to lack of Gen2 hardware, which is an honest disclosure. The API mappings from the old per-driver values to the new central UBWC helpers are correct based on my verification of the `` header. One minor style concern noted below. **Verdict: Series looks good. One minor nit on probe error handling.** --- --- Generated by Claude Code Patch Reviewer