From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/pm: Use guard(mutex) instead of manual lock+unlock Date: Sat, 16 May 2026 12:18:25 +1000 Message-ID: In-Reply-To: <20260508024744.6523-1-andrejhirata@usp.br> References: <20260508024744.6523-1-andrejhirata@usp.br> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amd/pm: Use guard(mutex) instead of manual lock+unlock Author: Andre Hirata Patches: 16 Reviewed: 2026-05-16T12:18:25.965626 --- This mbox contains three versions of the same single patch (RESEND/v1, v2, = v3) converting `drivers/gpu/drm/amd/pm/amdgpu_dpm.c` from manual `mutex_loc= k`/`mutex_unlock` pairs to the kernel `guard(mutex)` and `scoped_guard(mute= x)` cleanup API. The v3 is the latest and has a `Reviewed-by: Christian K= =C3=B6nig`. The intent is good and the overall direction is correct -- using `guard()` = eliminates a class of lock-leak bugs on early returns. However, **v3 has se= veral build-breaking syntax errors and one logic inversion bug** that must = be fixed before it can be applied. The patch will not compile as-is. **Verdict: Needs a v4 to fix the issues below.** --- Generated by Claude Code Patch Reviewer