From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Scheduler and submission fixes and refactoring Date: Sat, 16 May 2026 15:59:26 +1000 Message-ID: In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Scheduler and submission fixes and refactoring Author: =3D?utf-8?q?Ma=3DC3=3DADra_Canal?=3D Patches: 15 Reviewed: 2026-05-16T15:59:26.532315 --- This is a well-structured 14-patch series from Ma=C3=ADra Canal that cleans= up, fixes, and refactors the V3D scheduler and submission code. The series= progresses logically: trivial cleanups first (patches 1-4), then preparato= ry refactors (5-6), a mechanical API migration (7), the core abstraction in= troduction (8), and incremental conversions (9-12) leading to the key corre= ctness fixes (13-14, atomic submissions). The overall design is sound. The `struct v3d_submit` abstraction is well-mo= tivated =E2=80=94 the existing code managed multi-job submission chains wit= h ad-hoc local variables, and this centralizes the pattern cleanly. The fin= al atomicity fix in patch 14 (arm-all-then-push) is the main payoff and is = correct in approach. I have one concern worth flagging and a few minor observations, but nothing= that I'd consider a blocker. --- --- Generated by Claude Code Patch Reviewer