From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup Date: Sat, 16 May 2026 16:21:40 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-1-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup Author: Jonas Karlman Patches: 23 Reviewed: 2026-05-16T16:21:40.996983 --- This is a well-structured 21-patch cleanup series for the `dw-hdmi` bridge = driver by Jonas Karlman, part of a larger effort to upstream HDMI 2.0 suppo= rt for Rockchip RK33xx devices. The series is now at v5 and has collected s= everal reviewed-by tags from Neil Armstrong and Nicolas Frattaroli. **Theme**: The series simplifies the enable/disable path, fixes hotplug han= dling, migrates to modern DRM APIs (generic CEC notifier helpers, `display_= info` fields), adds HPD debouncing, and removes now-dead RXSENSE machinery.= The result is a net deletion of ~130 lines and significantly simpler code. **Strengths**: - Logical patch ordering with clean dependencies =E2=80=94 early patches se= t up the ability to remove code in later patches - Addresses real bugs: scrambler not cleared on hotplug to HDMI 1.4 sink (p= atch 1), spurious connected events on RX sense change (patch 2), use-after-= free on connector cleanup (patch 7), duplicate hotplug uevents (patch 21) - Good use of the modern `enable_delayed_work`/`disable_delayed_work` APIs = and `drmm_connector_hdmi_cec_notifier_register` - Thorough commit messages, especially patches 2, 16, 17, and 21 **Concerns**: A few minor issues noted below. The most significant is that = the `status` parameter to `dw_hdmi_connector_status_update()` (patch 11) go= es unused initially, creating a briefly misleading intermediate state. The = series also has a typo in patch 21's commit message. No blocking issues fou= nd. **Recommendation**: This series looks good for merging. The new patches in = v5 (7, 8, 15, 21) are sensible additions. The UAF fix in patch 7 is particu= larly important. --- Generated by Claude Code Patch Reviewer