From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format Date: Sat, 16 May 2026 16:14:37 +1000 Message-ID: In-Reply-To: <20260510183114.1248840-1-jonas@kwiboo.se> References: <20260510183114.1248840-1-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format Author: Jonas Karlman Patches: 11 Reviewed: 2026-05-16T16:14:37.782316 --- This is a well-structured 10-patch cleanup and preparation series for the `dw_hdmi-rockchip` driver by Jonas Karlman. Patches 1-7 are straightforward cleanups: modernizing match data retrieval, using `drmm_*` managed resources, inlining a helper, adding bridge refcounting, removing dead code, and cosmetic whitespace fixes. Patches 8-10 prepare for future YCbCr/Deep Color support by setting `output_port`, migrating to `atomic_mode_set()` with PHY configuration, and propagating bus format from the bridge state. The series is logically ordered and each patch is well-scoped. There is one **real bug** in patch 10 (incorrect error handling for `drm_atomic_get_bridge_state`), and one potential concern in patch 5 regarding error handling ordering. The rest is clean. **Verdict: Mostly good, one bug needs fixing in patch 10.** --- --- Generated by Claude Code Patch Reviewer