From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine. Date: Sat, 16 May 2026 15:26:36 +1000 Message-ID: In-Reply-To: <20260510185426.4264-1-gilles.risch@gmail.com> References: <20260510185426.4264-1-gilles.risch@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine. Author: Gilles Risch Patches: 1 Reviewed: 2026-05-16T15:26:36.767296 --- This is a single patch fixing display issues on the Apple iMac11,1 (late 2009, ATI Mobility Radeon HD 4850 / RV770). The core problem being fixed is real: the RV770 chip is DCE 3.2 hardware, but the existing `ASIC_IS_DCE32` macro (`>= CHIP_RV730`) accidentally excludes RV770 because `CHIP_RV770` precedes `CHIP_RV730` in the `radeon_family` enum. This causes PLL misconfiguration and wrong encoder selection on RV770-based Apple machines. However, the patch has **significant issues** with its approach, naming, commit message formatting, and missing sign-off. It should not be applied in its current form. --- Generated by Claude Code Patch Reviewer