From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: it66121: Fix display output on DVI monitors Date: Sat, 16 May 2026 16:11:54 +1000 Message-ID: In-Reply-To: <20260510191459.90769-1-javierm@redhat.com> References: <20260510191459.90769-1-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: it66121: Fix display output on DVI monitors Author: Javier Martinez Canillas Patches: 9 Reviewed: 2026-05-16T16:11:54.754926 --- This is a well-structured 3-patch series fixing a real DVI display output b= ug on the IT66121 bridge driver. The root cause =E2=80=94 unconditionally s= ending AVI infoframes and setting HDMI mode even for DVI sinks =E2=80=94 is= a known class of issue with HDMI bridges. The fix approach is sound: detec= t the sink type via EDID's `is_hdmi` flag and conditionally skip AVI infofr= ame setup and HDMI mode register configuration. The series is cleanly split: Patch 1 is a mechanical cleanup, Patch 2 adds = state infrastructure, and Patch 3 applies the fix. The testing coverage (DV= I monitor, HDMI-to-DVI adapter, HDMI monitor) is appropriate. There are two issues worth addressing, one functional and one style/correct= ness concern. --- Generated by Claude Code Patch Reviewer