public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dp/mst: fix OOB reads in remote DPCD/I2C sideband reply parsers
Date: Sat, 16 May 2026 16:07:31 +1000	[thread overview]
Message-ID: <review-overall-20260510201733.2882224-1-ashutoshdesai993@gmail.com> (raw)
In-Reply-To: <20260510201733.2882224-1-ashutoshdesai993@gmail.com>

Overall Series Review

Subject: drm/dp/mst: fix OOB reads in remote DPCD/I2C sideband reply parsers
Author: Ashutosh Desai <ashutoshdesai993@gmail.com>
Patches: 1
Reviewed: 2026-05-16T16:07:31.754498

---

This is a single-patch series that fixes two out-of-bounds read vulnerabilities in the DP MST sideband reply parsers. The fix is straightforward and correct: it ensures the full range of bytes to be copied (`idx + num_bytes`) is validated against `curlen` before each `memcpy`, rather than just checking the current index position.

The patch is well-motivated — `raw->msg[]` is 256 bytes and `curlen` is `u8` (max 255), so a malicious or misbehaving MST hub could craft a reply with `num_bytes` set larger than the remaining payload, causing the `memcpy` to read past the valid message data. Both destination buffers (`bytes[255]`) are large enough for the max `u8` value, so no destination overflow is possible — the issue is purely about reading past the received data in `raw->msg[]`.

**Verdict: Looks good.** The fix is minimal, correct, and appropriate for stable backport.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 20:17 [PATCH v2] drm/dp/mst: fix OOB reads in remote DPCD/I2C sideband reply parsers Ashutosh Desai
2026-05-16  6:07 ` Claude Code Review Bot [this message]
2026-05-16  6:07 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-10  3:41 [PATCH] " Ashutosh Desai
2026-04-12  0:33 ` Claude review: " Claude Code Review Bot
2026-04-12  0:33 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260510201733.2882224-1-ashutoshdesai993@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox