Claude review: drm/msm/dp: Skip push_idle in atomic_disable if display is not powered on

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/dp: Skip push_idle in atomic_disable if display is not powered on
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-05-16T15:42:51.497192

---

This is a single-patch fix for a real crash scenario on Qualcomm eDP interfaces. When an eDP connector has no panel attached, the probe-time DPCD read fails, leaving `hpd_state` at `ST_DISCONNECTED`. Consequently `msm_dp_bridge_atomic_enable()` exits early, `power_on` stays `false`, and link clocks are never enabled. During system suspend, `drm_atomic_helper_suspend()` still calls `atomic_disable()` on all registered bridges, and `msm_dp_ctrl_push_idle()` writes to `REG_DP_STATE_CTRL` on an unpowered controller — triggering a NoC slave error and a fatal crash.

The fix is straightforward and correct in principle: guard `msm_dp_ctrl_push_idle()` with a `power_on` check. This is consistent with how `msm_dp_display_disable()` (called from the subsequent `atomic_post_disable`) already guards itself with `if (!msm_dp_display->power_on) return 0;`.

**Verdict: The patch looks correct and the approach is reasonable.** One minor concern below.

---
Generated by Claude Code Patch Reviewer