From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: add support for Silergy SY7758 Date: Sat, 16 May 2026 16:17:41 +1000 Message-ID: In-Reply-To: <20260511-sy7758-v1-0-999a33081304@gmail.com> References: <20260511-sy7758-v1-0-999a33081304@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: backlight: add support for Silergy SY7758 Author: Alexandre Hamamdjian via B4 Relay Patches: 4 Reviewed: 2026-05-16T16:17:41.648861 --- This is a 2-patch series adding a DT binding and driver for the Silergy SY7758 I2C LED backlight controller, used on the Ayaneo Pocket DS handheld. The binding is reasonable and uses the common backlight schema. The driver is functional in concept but has several issues ranging from correctness bugs to code quality problems that should be addressed before merge. The most significant issues are: (1) a global static mutex that breaks multi-instance correctness, (2) no error checking on any I2C register writes, (3) a brightness encoding that silently maps userspace values 1-15 to hardware-zero, (4) magic register values throughout `sy7758_init()` with no symbolic names, and (5) DT properties `default-brightness` and `max-brightness` advertised in the binding example but never read by the driver. --- --- Generated by Claude Code Patch Reviewer