From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: determine the hotspots attribute first Date: Sat, 16 May 2026 15:55:01 +1000 Message-ID: In-Reply-To: <20260511021926.67673-1-yaolu@kylinos.cn> References: <20260511021926.67673-1-yaolu@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: determine the hotspots attribute first Author: yaolu@kylinos.cn Patches: 1 Reviewed: 2026-05-16T15:55:01.344626 --- This is a single-patch series that reorders the `if-else` chain in `drm_ato= mic_plane_set_property()` and `drm_atomic_plane_get_property()` so that the= hotspot property checks happen *before* the driver `atomic_set/get_propert= y` callback fallback. **The fix is logically correct.** The driver callback is a catch-all fallba= ck for driver-specific properties and should always come last, just before = the "unknown property" error case. Having it in the middle of core property= checks was a latent bug =E2=80=94 if any driver with `DRIVER_CURSOR_HOTSPO= T` also implemented `plane->funcs->atomic_set_property`, the hotspot proper= ties would be swallowed by the driver callback and never reach the core han= dling code. **Practical impact is currently low.** I checked the four drivers that set = `DRIVER_CURSOR_HOTSPOT` (vmwgfx, virtio-gpu, vboxvideo, qxl) and none of th= em implement plane-level `atomic_set/get_property`. vmwgfx has connector-le= vel callbacks only. So this is a defensive fix against a currently-theoreti= cal bug, but still worth doing =E2=80=94 the ordering was clearly wrong and= fragile. **The commit message and metadata need significant improvement** before thi= s should be merged. --- Generated by Claude Code Patch Reviewer