From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Date: Sat, 16 May 2026 12:19:33 +1000 Message-ID: In-Reply-To: <20260511063941.2070-1-yanlonglong@kylinos.cn> References: <20260511063941.2070-1-yanlonglong@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: synopsys: dw-dp: fix bool function returning negative = error code Author: Bob ynn Patches: 1 Reviewed: 2026-05-16T12:19:33.015984 --- This is a single-patch series fixing a clear bug: a `bool`-returning functi= on (`dw_dp_video_need_vsc_sdp`) was returning `-EINVAL` on an error path. S= ince `-EINVAL` is `-22` (non-zero), it gets implicitly converted to `true`,= which is the opposite of the safe/intended behavior =E2=80=94 it would inc= orrectly signal that a VSC SDP is needed when the bridge state can't be ret= rieved. The fix is minimal, correct, and appropriate. Returning `false` on failure = is the conservative and safe choice here: if the bridge state can't be obta= ined, the function should not claim a VSC SDP is needed. **Verdict: The patch looks good and should be accepted.** --- Generated by Claude Code Patch Reviewer