Claude review: drm/verisilicon: add Nuvoton MA35D1 DCUltra Lite support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/verisilicon: add Nuvoton MA35D1 DCUltra Lite support
Author: Joey Lu <a0987203069@gmail.com>
Patches: 17
Reviewed: 2026-05-16T15:45:51.619748

---

This 2-patch series adds support for the Nuvoton MA35D1 DCUltra Lite display controller to the existing Verisilicon DC driver. The approach of introducing a `vs_dc_info` platform data structure to describe per-variant capabilities is sound and follows standard kernel driver patterns for multi-variant IP blocks.

**Strengths:**
- The `vs_dc_info` abstraction is clean and extensible for future variants
- The DT binding factoring (base schema + sub-schema) is the right pattern
- Good use of `has_config_ex` boolean to gate CONFIG_EX register accesses
- Cover letter is thorough and well-documented

**Concerns:**
- The IRQ handler for DCUltra Lite unconditionally returns `IRQ_HANDLED` even when no interrupt is pending, which will mask shared-IRQ problems
- The DCUltra Lite `vs_dc_irq_handler` does not acknowledge/clear the IRQ status, which could cause an IRQ storm
- The DT binding base schema change to `additionalProperties: true` is overly permissive
- The `compatible` schema change from ordered list to `contains` breaks the DC8000 binding semantics
- The plane disable path for DCUltra Lite does nothing useful (no CONFIG_EX, no FB_CONFIG disable bit)

---

---
Generated by Claude Code Patch Reviewer