From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem: Remove unneeded ret check in change handle ioctl Date: Sat, 16 May 2026 15:11:29 +1000 Message-ID: In-Reply-To: <20260511142540.2989187-1-jonathan.cavitt@intel.com> References: <20260511142540.2989187-1-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/gem: Remove unneeded ret check in change handle ioctl Author: Jonathan Cavitt Patches: 3 Reviewed: 2026-05-16T15:11:29.210502 --- This is a single-patch series that attempts to remove what it claims is a d= ead `if (ret < 0)` check after `idr_replace` in `drm_gem_change_handle_ioct= l`. However, **the patch is based on an older version of the code that has = since been refactored**. The current drm-next tree no longer uses `idr_repl= ace` in this function =E2=80=94 it was reworked to use `idr_alloc` + `idr_r= emove`. The patch does not apply cleanly, and the issue it addresses no lon= ger exists in the current code. **Recommendation: NAK / Obsolete** =E2=80=94 the code the patch targets has= already been restructured, making this change moot. --- Generated by Claude Code Patch Reviewer