From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ttm: Fix ttm_bo_shrink() infinite LRU walk on backup failure Date: Sat, 16 May 2026 15:07:24 +1000 Message-ID: In-Reply-To: <20260511162443.24352-1-thomas.hellstrom@linux.intel.com> References: <20260511162443.24352-1-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/ttm: Fix ttm_bo_shrink() infinite LRU walk on backup failure Author: =3D?UTF-8?q?Thomas=3D20Hellstr=3DC3=3DB6m?=3D Patches: 4 Reviewed: 2026-05-16T15:07:24.448965 --- This is a single patch fixing an infinite LRU walk bug in `ttm_bo_shrink()`= , mirroring a prior fix (b2ed01e7ad) applied to the `ttm_bo_swapout()` path= . The fix is logically correct: it eliminates the problematic pattern of re= moving a resource from bulk_move before the backup attempt and re-adding on= failure, which could disrupt cursor-based LRU iteration and cause infinite= walks. The approach =E2=80=94 only touching bulk_move/LRU state after successful b= ackup =E2=80=94 is clean and consistent with the analogous swapout fix. **Key dependency:** This patch uses `ttm_resource_del_bulk_move_unevictable= ()`, which does not exist in the current drm-next tree. It is presumably in= troduced by commit b2ed01e7ad. This patch cannot be applied standalone; the= prerequisite must be present. --- --- Generated by Claude Code Patch Reviewer