From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu/buddy: Per-order free and used block scoreboards Date: Sat, 16 May 2026 14:58:07 +1000 Message-ID: In-Reply-To: <20260511164217.150237-1-francois.dugast@intel.com> References: <20260511164217.150237-1-francois.dugast@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu/buddy: Per-order free and used block scoreboards Author: Francois Dugast Patches: 5 Reviewed: 2026-05-16T14:58:07.515061 --- This is a well-structured 3-patch series against the `gpu_buddy` allocator. Patch 1 fixes a real use-after-free / rbtree corruption bug in four error-undo paths, patches 2 and 3 add per-order free and used block scoreboards to make `drm_buddy_print()` / `gpu_buddy_print()` O(1) instead of O(n). The bug fix in patch 1 is correct and follows the established pattern from `__force_merge()`. The scoreboard accounting in patches 2 and 3 is carefully placed at every state-transition point and I was unable to find a path that would cause a missed increment, double-decrement, or underflow. **Overall: series looks good, with minor nits below.** --- --- Generated by Claude Code Patch Reviewer