From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: Consolidate "sram" property definition Date: Sat, 16 May 2026 14:53:56 +1000 Message-ID: In-Reply-To: <20260511165942.2774868-1-robh@kernel.org> References: <20260511165942.2774868-1-robh@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dt-bindings: Consolidate "sram" property definition Author: "Rob Herring (Arm)" Patches: 10 Reviewed: 2026-05-16T14:53:56.864908 --- This is a single patch from Rob Herring (DT binding maintainer) that creates a common `sram-consumer.yaml` schema using the well-established `select: true` consumer pattern (already used by nvmem-consumer, leds-consumer, mux-consumer, etc.) and removes the duplicated `sram` property definitions from 15 individual binding files. The approach is sound and follows established dt-bindings conventions. The common schema defines `sram` as a `phandle-array` with `items: maxItems: 1` (no arg cells), while device-specific schemas retain their own `minItems`/`maxItems` constraints and device-specific descriptions. The files that previously defined `sram` as a plain `phandle` (single entry) are compatible with the `phandle-array` definition since they retain `maxItems: 1`. Overall this is a straightforward de-duplication cleanup. One minor concern worth raising is noted below. **Verdict: Looks good. One minor question on the stericsson DMA40 change.** --- --- Generated by Claude Code Patch Reviewer