Claude review: drm/loongson: clean up KMS polling on probe failure

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/loongson: clean up KMS polling on probe failure
Author: Myeonghun Pak <mhun512@gmail.com>
Patches: 4
Reviewed: 2026-05-16T14:50:22.210155

---

This is a single patch that addresses a real bug: `drm_kms_helper_poll_init()` is called during probe but `drm_kms_helper_poll_fini()` is never called on either the error paths or the remove path. The analysis is correct — the polling timer/work would leak on probe failure and on device removal.

However, **the proposed fix is not the right approach**. The loongson driver already uses `devm_drm_dev_alloc()` and `drmm_mode_config_init()` — it follows the DRM managed resource pattern. The proper fix is to replace `drm_kms_helper_poll_init()` with `drmm_kms_helper_poll_init()` (a one-line change), which registers a managed cleanup action so that `drm_kms_helper_poll_fini()` is called automatically when the DRM device is torn down. This eliminates the need for any manual `goto` cleanup labels or explicit `poll_fini` calls in remove.

Additionally, the remove-path change has an ordering concern: the patch places `drm_kms_helper_poll_fini()` **before** `drm_dev_unregister()`, but the standard tear-down order (as seen in e.g. `verisilicon/vs_drm.c`) is to unregister first, then finalize polling. Calling `poll_fini` while the device is still registered could race with connector probing triggered by userspace.

---
Generated by Claude Code Patch Reviewer