From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Rework initial state allocation Date: Sat, 16 May 2026 13:22:51 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: Rework initial state allocation Author: Maxime Ripard Patches: 21 Reviewed: 2026-05-16T13:22:51.675458 --- This is a well-structured 20-patch series from Maxime Ripard that introduce= s a new `atomic_create_state` callback pattern for DRM planes, CRTCs, and c= onnectors (previously only available for `drm_private_obj`), and creates a = new `drm_mode_config_create_initial_state()` helper to cleanly separate ini= tial state creation from suspend/resume reset. The motivation is sound: `reset()` is overloaded =E2=80=94 used for initial= state allocation, hardware reset, and suspend/resume =E2=80=94 making it h= ard to reason about side effects and error handling. The new `atomic_create= _state` is fallible, side-effect-free, and purely for state allocation/init= ialization. The series is well-ordered: documentation and typo fixes first, then rename= s (`_reset` -> `_init`), then the new callbacks for each object type, then = the central `drm_mode_config_create_initial_state()`, and finally driver co= nversions (tidss, bridge_connector). **There is one real bug** in patch 16 =E2=80=94 a connector list iterator l= eak on error. Most other patches are straightforward and correct. The serie= s has good review coverage (Laurent Pinchart, Thomas Zimmermann, Dmitry Bar= yshkov, Tomi Valkeinen). --- Generated by Claude Code Patch Reviewer