From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Devicetree support for Glymur GPU Date: Sat, 16 May 2026 14:42:41 +1000 Message-ID: In-Reply-To: <20260512-glymur-gpu-dt-v3-0-84232dc21c03@oss.qualcomm.com> References: <20260512-glymur-gpu-dt-v3-0-84232dc21c03@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Devicetree support for Glymur GPU Author: Akhil P Oommen Patches: 7 Reviewed: 2026-05-16T14:42:41.960670 --- This is a v3 series adding Device Tree support for the Adreno X2-85 GPU (chip ID 0x44070001, family A8x Gen2) on the Qualcomm Glymur SoC. The series is well-structured: driver fix first (patch 1), then DT bindings (patches 2-3), then DT nodes (patches 4-5). The GPU and SMMU support in the kernel driver already exists (confirmed in `a6xx_catalog.c`), so this series is purely about wiring up the DT for a new board. Overall the series looks **reasonable and close to mergeable**. The RSCC fix (patch 1) is a genuine bug fix affecting all A8xx GPUs, and the DT additions follow established patterns from sm8650/sm8750. A few observations below. --- --- Generated by Claude Code Patch Reviewer