From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: imx93-mipi-dsi: Fix mode validation Date: Sat, 16 May 2026 13:49:54 +1000 Message-ID: In-Reply-To: <20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com> References: <20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: imx93-mipi-dsi: Fix mode validation Author: Liu Ying Patches: 2 Reviewed: 2026-05-16T13:49:54.773137 --- This is a single-patch fix for the imx93 MIPI DSI bridge driver's mode validation logic. The bug is real and well-described: the original code checked only the last bridge in the chain for `DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID`, but the last bridge is typically a connector bridge without those ops set. The fix iterates over the bridge chain to find any bridge with those capabilities, which correctly enables the +/-0.5% pixel clock tolerance for EDID-sourced modes. The patch is clean, correct, and well-explained. The use of `drm_for_each_bridge_in_chain_from()` is appropriate and replaces the manual `drm_bridge_chain_get_last_bridge()` + `__free(drm_bridge_put)` pattern with the iterator's built-in cleanup. **Reviewed-by is appropriate.** --- Generated by Claude Code Patch Reviewer