From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: Devicetree support for Kaanapali GPU Date: Sat, 16 May 2026 14:35:12 +1000 Message-ID: In-Reply-To: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> References: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: arm64: dts: qcom: Devicetree support for Kaanapali GPU Author: Akhil P Oommen Patches: 24 Reviewed: 2026-05-16T14:35:12.609537 --- This is a well-structured 8-patch series adding GPU support for the Qualcomm Kaanapali SoC (Adreno 840, A8x family). The series covers the full stack: DT bindings, SMMU, qfprom speed-bin, GPU/GMU nodes, thermal cooling, and board-level enablement for MTP and QRD platforms. The series depends on prerequisite patches (Glymur GPU DT v3 and clock fixes v2), which explains why it doesn't apply cleanly to the current drm-next tree. The series is generally clean and follows established patterns from other recent Qualcomm SoCs. There is one node-ordering issue in the main GPU patch that should be corrected before merging. **Key issue:** In patch 5, the `gmu@3d6c000` node is placed before `gxclkctl@3d64000`, violating the convention that DT nodes should be sorted by unit address. --- --- Generated by Claude Code Patch Reviewer