From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: set __GFP_SKIP_KASAN Date: Sat, 16 May 2026 13:08:46 +1000 Message-ID: In-Reply-To: <20260512-panthor-kasan-v1-1-d8d3e275d71b@gmail.com> References: <20260512-panthor-kasan-v1-1-d8d3e275d71b@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: set __GFP_SKIP_KASAN Author: Chia-I Wu via B4 Relay Patches: 3 Reviewed: 2026-05-16T13:08:46.783545 --- This is a single, well-motivated patch that fixes a real KASAN invalid-acce= ss bug on CONFIG_KASAN_HW_TAGS=3Dy systems with MTE-capable hardware (recen= t Snapdragon SoCs). The problem is clearly explained: `shmem_swapin_cluster= ` can swap in pages belonging to other PROT_MTE mappings using panthor's GF= P flags, and without `__GFP_SKIP_KASAN`, the page allocator assigns a speci= fic KASAN tag to the kernel mapping instead of the match-all tag, leading t= o tag mismatch crashes. The fix is correct. The approach of deriving the flags from `GFP_HIGHUSER_M= OVABLE` rather than directly adding `__GFP_SKIP_KASAN` to the existing expr= ession is a reasonable choice that better matches the semantic intent =E2= =80=94 these are user-facing pages that should behave like `GFP_HIGHUSER_MO= VABLE` except they must not be movable (because panthor pins them). **Verdict: The patch looks correct and ready for merging**, with minor styl= e observations below. --- Generated by Claude Code Patch Reviewer