From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Reduce dma_fence signalling latency Date: Sat, 16 May 2026 13:32:44 +1000 Message-ID: In-Reply-To: <20260512-panthor-signal-from-irq-v2-0-95c614a739cb@collabora.com> References: <20260512-panthor-signal-from-irq-v2-0-95c614a739cb@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: Reduce dma_fence signalling latency Author: Boris Brezillon Patches: 41 Reviewed: 2026-05-16T13:32:44.342336 --- This is a well-structured 11-patch series by Boris Brezillon that moves pan= thor's JOB and GPU interrupt processing from threaded IRQ handlers / work i= tems into the hard IRQ handler, reducing dma_fence signalling latency by ~5= % on rk3588. The series follows a clean progression: 1. **Patches 1-4**: Mechanical refactoring =E2=80=94 make IRQ state non-ato= mic, reorder code, replace macro machinery with inline helpers, and add the= hard-handler plumbing. 2. **Patch 5**: Make FW req helpers IRQ-safe (`spinlock_irqsave`). 3. **Patches 6-7**: Prepare the scheduler for IRQ-context event processing = =E2=80=94 introduce `events_lock`, inline fence signalling, automate CSG IR= Q processing at unbind. 4. **Patch 8**: Optimize interrupt usage with on-demand `ack_irq_mask` enab= lement. 5. **Patches 9-11**: Actually switch JOB and GPU IRQ processing to the hard= handler. The overall approach is sound. The MMU handler is correctly left as a threa= ded handler since it needs sleepable locks. The lock conversion to `irqsave= ` variants is methodical and mostly correct. Patches 1-4 already have Revie= wed-by tags from Steven Price and Liviu Dudau. There are a few concerns worth raising, primarily around patch 9's custom I= RQ handling logic and the interaction of `events_lock` scope with `group_un= bind_locked`. --- --- Generated by Claude Code Patch Reviewer