From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: driver core: remove software node from platform devices on device release Date: Sat, 16 May 2026 13:28:29 +1000 Message-ID: In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> References: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: driver core: remove software node from platform devices on device = release Author: Bartosz Golaszewski Patches: 14 Reviewed: 2026-05-16T13:28:29.489538 --- This is a well-motivated 7-patch series from Bartosz Golaszewski fixing a s= oftware node leak in the platform device subsystem: when a software node is= passed via `struct platform_device_info`, it is not removed on device `.re= lease()`, causing a `-EBUSY` on reuse. The overall approach =E2=80=94 conve= rt affected drivers, add a new helper, then fix the core =E2=80=94 is sound. However, **two of the driver-conversion patches (1/7 and 4/7) have bugs in = the cleanup/unregister paths** that would cause use-after-free or use-of-un= initialized-value issues. These need to be fixed before the series can land. The core platform changes (patches 2, 3, 5) and the kunit additions (patche= s 6, 7) look correct. --- --- Generated by Claude Code Patch Reviewer