From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: use managed KMS polling Date: Sat, 16 May 2026 14:17:59 +1000 Message-ID: In-Reply-To: <20260512063657.53100-1-mhun512@gmail.com> References: <20260512063657.53100-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/loongson: use managed KMS polling Author: Myeonghun Pak Patches: 5 Reviewed: 2026-05-16T14:17:59.205016 --- This is a single-patch series that converts the loongson DRM driver from `drm_kms_helper_poll_init()` to the managed variant `drmm_kms_helper_poll_init()`. The change is correct, well-motivated, and minimal. The commit message clearly describes the problem: `lsdc_pci_probe()` calls `drm_kms_helper_poll_init()` early, but if subsequent steps (`drm_vblank_init`, `devm_request_irq`, `drm_dev_register`) fail, the probe function returns without calling `drm_kms_helper_poll_fini()`. Additionally, `lsdc_pci_remove()` (line 324-330 of `lsdc_drv.c`) never calls `drm_kms_helper_poll_fini()` either, so even on clean removal, polling resources leak. The fix is appropriate: `drmm_kms_helper_poll_init()` uses `drmm_add_action_or_reset()` to tie the poll cleanup to the DRM device lifetime, so finalization happens automatically on both error-path teardown and normal device removal. **Verdict: Looks good.** This is a clean, minimal fix following the same pattern already adopted by `ast`, `hibmc`, and `udl` drivers in-tree. --- Generated by Claude Code Patch Reviewer