From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge Date: Sat, 16 May 2026 14:16:44 +1000 Message-ID: In-Reply-To: <20260512064013.40066-1-syyang@lontium.com> References: <20260512064013.40066-1-syyang@lontium.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge Author: syyang@lontium.com Patches: 3 Reviewed: 2026-05-16T14:16:44.993415 --- This is a v7 2-patch series adding a Lontium LT7911EXC eDP-to-MIPI-DSI bridge driver. The DT binding (patch 1) has already been reviewed by Krzysztof Kozlowski and the driver (patch 2) by Dmitry Baryshkov. The DT binding is clean and looks good. The driver has one **critical issue**: it uses atomic bridge callbacks (`atomic_pre_enable`, `atomic_disable`, `atomic_post_disable`) without providing the mandatory atomic state bookkeeping callbacks (`atomic_duplicate_state`, `atomic_destroy_state`, `atomic_reset`). All 40 other bridge drivers in the tree that use atomic callbacks provide these. Without `atomic_reset`, `drm_bridge_is_atomic()` returns false and the bridge private state object is never initialized, which can cause problems with the DRM atomic framework. Beyond that, there are several medium-severity issues around error handling, sysfs interface design, and unused includes. The patches are also based on an older tree -- drm-next has since refactored the atomic bridge callback signatures from `struct drm_atomic_state *` to `struct drm_atomic_commit *`, so a rebase will be needed. --- --- Generated by Claude Code Patch Reviewer