From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: use managed KMS polling Date: Sat, 16 May 2026 14:07:27 +1000 Message-ID: In-Reply-To: <20260512065436.74729-1-mhun512@gmail.com> References: <20260512065436.74729-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/loongson: use managed KMS polling Author: Myeonghun Pak Patches: 2 Reviewed: 2026-05-16T14:07:27.468757 --- This is a single-patch series that replaces `drm_kms_helper_poll_init()` with its managed counterpart `drmm_kms_helper_poll_init()` in the loongson display controller driver. The fix is correct and well-motivated. **The problem is real:** `lsdc_pci_probe()` calls `drm_kms_helper_poll_init()` at line 296, but if subsequent steps fail (`drm_vblank_init`, `devm_request_irq`, or `drm_dev_register`), the function returns without calling `drm_kms_helper_poll_fini()`. Furthermore, `lsdc_pci_remove()` also never calls `drm_kms_helper_poll_fini()`, so polling is never finalized even on normal device removal. The managed variant ties the polling lifecycle to the DRM device and handles cleanup automatically. **Verdict: Patch looks good.** One minor observation below. --- Generated by Claude Code Patch Reviewer