From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Revert "i915: don't use a vma that didn't match the context VM" Date: Sat, 16 May 2026 13:59:28 +1000 Message-ID: In-Reply-To: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com> References: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Revert "i915: don't use a vma that didn't match the context VM" Author: Joonas Lahtinen Patches: 2 Reviewed: 2026-05-16T13:59:28.286020 --- This is a single-patch revert of commit `5401b9adebc9`, which had added an = explicit `else vma =3D NULL` branch to `eb_lookup_vma()`. The patch is corr= ect: the removed code is indeed a no-op, and the revert is clean and well-j= ustified. **Verdict: Looks good.** The `radix_tree_lookup()` function already returns `NULL` when the key is n= ot found, so the `else vma =3D NULL` assignment is redundant =E2=80=94 `vma= ` is already `NULL` in that branch. The only remaining question is whether = the explicit assignment served a defensive/clarity purpose, but as the comm= it message explains (with a link to the Linus discussion), the original com= mit was motivated by a UAF concern that hasn't been possible since 2021. Re= moving dead defensive code that was added under a false premise is reasonab= le. --- Generated by Claude Code Patch Reviewer