Claude review: Add eDP support for RK3576

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add eDP support for RK3576
Author: Damon Ding <damon.ding@rock-chips.com>
Patches: 15
Reviewed: 2026-05-16T13:47:58.040579

---

This is a well-structured v4 series adding eDP support for the Rockchip RK3576 SoC. The series is logically organized in three phases: (1) fixing the missing `hclk` clock for existing RK3588 eDP (patches 1-5), (2) adding the RK3576 eDP DT node (patches 6-7), and (3) adding driver support for RK3576 (patches 8-10).

The approach of reusing the RK3588 design is sensible given the hardware is described as fully compatible. The code changes are minimal and mechanical, which is appropriate for adding a new SoC variant to an existing driver. The series has already collected several Reviewed-by tags from Luca Ceresoli and Nicolas Frattaroli.

**Concerns:**
- The RK3576 chip_data is notably sparse compared to RK3588's (no `edp_mode` GRF field), which needs scrutiny.
- The `rockchip,grf` property in the RK3576 DT node points to `vo0_grf` but no `rockchip,vo-grf` is defined (unlike RK3588). This may be intentional but needs clarification.
- Patch ordering could be improved: the Fixes-tagged patches (1-5) should arguably not depend on patches that don't carry Fixes tags.

Overall: **Looks mostly good with minor issues to address.**

---

---
Generated by Claude Code Patch Reviewer