From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: it66121: Fix display output on DVI monitors Date: Sat, 16 May 2026 13:19:45 +1000 Message-ID: In-Reply-To: <20260512132232.333654-1-javierm@redhat.com> References: <20260512132232.333654-1-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: it66121: Fix display output on DVI monitors Author: Javier Martinez Canillas Patches: 7 Reviewed: 2026-05-16T13:19:45.709854 --- This is a well-motivated 2-patch series fixing a real bug: the it66121 brid= ge driver unconditionally sets HDMI TX mode and enables AVI infoframes, whi= ch breaks display output on DVI monitors. The approach is sound =E2=80=94 p= atch 1 moves the TX mode/infoframe configuration from `.mode_set` to `.atom= ic_enable` (where `ctx->connector` is available), and patch 2 makes the con= figuration conditional on `display_info.is_hdmi`. However, there is a significant issue: **patch 1 does not remove the existi= ng TX mode and AVI infoframe writes from `.mode_set`**. The new `it66121_se= t_tx_mode()` function added in `.atomic_enable` duplicates the `IT66121_HDM= I_MODE_REG` and `IT66121_AVI_INFO_PKT_REG` writes that remain in `it66121_b= ridge_mode_set()` (lines 796-803 of the current tree). This means both call= backs write these registers, and the `.mode_set` write (which runs first) s= till unconditionally sets HDMI mode. The fix in patch 2 only changes the ne= w function in `.atomic_enable`, so the `.mode_set` code will still force HD= MI mode before `.atomic_enable` overrides it with the correct value. While = the final state should be correct (`.atomic_enable` runs after `.mode_set`)= , this is confusing and fragile =E2=80=94 the duplicate writes should be cl= eaned up. The series is otherwise clean and correctly addresses the v2 feedback from = Maxime. --- Generated by Claude Code Patch Reviewer