From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Add BeagleY-AI display support (and some more) Date: Sat, 16 May 2026 12:00:14 +1000 Message-ID: In-Reply-To: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> References: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/tidss: Add BeagleY-AI display support (and some more) Author: Tomi Valkeinen Patches: 23 Reviewed: 2026-05-16T12:00:14.716115 --- This is a well-structured 16-patch series from Tomi Valkeinen adding display support for the BeagleY-AI board (TI AM62P/J722S SoCs). The series covers DT bindings, driver changes, and board DTS. The main highlights: 1. **DT binding refactoring** (patches 1-5): Splits AM62L into its own binding file, simplifies the AM65x binding, adds OLDI power-domain, adds `ti,dpi-io-ctrl` for signal edge config, and adds AM62P DSS compatible. 2. **Driver cleanups** (patches 6-7): Removes redundant `pm_runtime_mark_last_busy` and unused OLDI register define. 3. **DPI detection and signal edge support** (patches 8-10): Adds mechanism to detect DPI output, configures external DPI0_CLK_CTRL register via syscon, and adds DPIENABLE bit support for power savings. 4. **OLDI fixes and aux driver conversion** (patches 11-12): Fixes signal polarity handling, then converts OLDI to auxiliary device/driver for proper power-domain management. 5. **AM62P support and board DTS** (patches 13-16): Adds AM62P compatible, makes main_conf a syscon, adds DSS/OLDI/DSI/DPHY nodes, enables HDMI on BeagleY-AI. Overall the series is solid work with good commit messages explaining the "why". Most DT binding patches already have Rob's Reviewed-by. A few issues worth addressing are noted below. --- Generated by Claude Code Patch Reviewer