From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: cgroup/dmem: introduce a peak file Date: Sat, 16 May 2026 11:20:49 +1000 Message-ID: In-Reply-To: <20260513-dmem_peak-v2-1-dac06999db9e@igalia.com> References: <20260513-dmem_peak-v2-1-dac06999db9e@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: cgroup/dmem: introduce a peak file Author: Thadeu Lima de Souza Cascardo Patches: 2 Reviewed: 2026-05-16T11:20:49.360654 --- This is a clean, well-scoped single patch that adds a `dmem.peak` cgroup file to the device memory (dmem) cgroup controller, mirroring the existing `memory.peak` pattern. The implementation correctly reuses the existing `dmemcg_limit_show` callback infrastructure and the `page_counter` watermark tracking that is already in place. The patch is minimal and follows established patterns in the codebase. **Verdict: Looks good overall.** A couple of minor observations below but nothing blocking. --- Generated by Claude Code Patch Reviewer