From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: display-connector: detect DP state if cable is plugged on boot Date: Sat, 16 May 2026 11:28:15 +1000 Message-ID: In-Reply-To: <20260513-dp-connector-hpd-v2-0-42f757bfcbf9@oss.qualcomm.com> References: <20260513-dp-connector-hpd-v2-0-42f757bfcbf9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: display-connector: detect DP state if cable is plugged= on boot Author: Dmitry Baryshkov Patches: 3 Reviewed: 2026-05-16T11:28:15.749364 --- This is a well-targeted 2-patch series from Dmitry Baryshkov fixing a real = boot-time HPD detection problem for DisplayPort connectors using the `displ= ay-connector` bridge driver. The core issue: if a DP cable is plugged in be= fore the system boots, the HPD GPIO line is already asserted, so no edge in= terrupt fires, and the DP controller never learns about the connected displ= ay. The approach is sound: (1) defer IRQ enablement from probe to the `hpd_enab= le` bridge callback, and (2) schedule a work item to send an initial HPD no= tification for DP connectors. The work_struct is correctly used to avoid a = mutex deadlock =E2=80=94 `drm_bridge_hpd_enable()` holds `bridge->hpd_mutex= ` when calling `hpd_enable`, and `drm_bridge_hpd_notify()` also takes that = same mutex, so calling it directly from `hpd_enable` would deadlock. Both patches are clean, minimal, and correctly ordered. A couple of minor i= ssues noted below. **Verdict: Looks good, minor nits only.** --- --- Generated by Claude Code Patch Reviewer