From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi & phy: use generic PHY framework Date: Sat, 16 May 2026 11:32:09 +1000 Message-ID: In-Reply-To: <20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com> References: <20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/hdmi & phy: use generic PHY framework Author: Dmitry Baryshkov Patches: 6 Reviewed: 2026-05-16T11:32:09.688325 --- This is v9 of a well-structured series by Dmitry Baryshkov that migrates the MSM HDMI PHY drivers from the ad-hoc DRM-internal API (`drivers/gpu/drm/msm/hdmi/hdmi_phy*.c`) to the generic Linux PHY subsystem (`drivers/phy/qualcomm/`). The series removes ~2857 lines from `drm/msm` and adds ~2063 new lines under `drivers/phy/qualcomm/`, with subsequent patches adding MSM8974 support and converting the 28lpm PHY from fixed lookup tables to runtime-calculated PLL configuration. **Architecture**: The split into preqmp (32-bit SoC PHYs) and QMP (64-bit SoC PHYs) drivers is clean. The use of `phy_configure()` with `phy_configure_opts_hdmi` to pass `tmds_char_rate` is the correct approach for the generic PHY framework. **Overall quality**: This is a mature series at v9 with reviews/acks from Neil Armstrong and Konrad Dybcio. The code is well organized, resource management follows kernel best practices with `devm_*` functions, and error paths are handled correctly. The main concerns are some duplicated helper functions and a minor Kconfig typo. **Merge strategy**: The cover letter proposes merging patch 1 in this cycle (through drm/msm or PHY tree), then the rest in the next cycle. This is reasonable since patch 1 is the enabling infrastructure and patches 2-5 layer cleanly on top. --- Generated by Claude Code Patch Reviewer