From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Attach a driver to GMU Date: Sat, 16 May 2026 12:47:07 +1000 Message-ID: In-Reply-To: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> References: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: Attach a driver to GMU Author: Akhil P Oommen Patches: 13 Reviewed: 2026-05-16T12:47:07.090237 --- This 5-patch series addresses `sync_state()` warnings from genpd when the GMU device node has no driver bound. The approach is to register a proper platform driver for the GMU and integrate it as a component device alongside the GPU in the DRM component model. The series is logically structured: patches 1-3 are preparatory fixes, patch 4 restructures the standalone GPU path to always use the component framework, and patch 5 introduces the GMU driver. The overall direction is sound, but the key mechanism in patch 5 -- passing the `a6xx_gpu` pointer to the GMU bind callback via `platform_set_drvdata` on another device -- is fragile and introduces a cross-component coupling that could lead to a dangling pointer on error paths. This should be addressed before merging. The series is marked RFT (Request For Testing) which is appropriate given the scope of changes. --- --- Generated by Claude Code Patch Reviewer