From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use guards Date: Sat, 16 May 2026 11:40:44 +1000 Message-ID: In-Reply-To: <20260513-panthor-guard-refactor-v1-0-f2d8c15a97ce@collabora.com> References: <20260513-panthor-guard-refactor-v1-0-f2d8c15a97ce@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: Use guards Author: Boris Brezillon Patches: 14 Reviewed: 2026-05-16T11:40:44.787945 --- This is a well-structured 6-patch series from Boris Brezillon converting pa= nthor's mixture of manual lock/unlock patterns to use the kernel's `guard()= `/`scoped_guard()` infrastructure. The series is sensibly ordered: patch 1 = handles the bulk mechanical conversion for locks that already have guards, = patches 2-3 introduce new guards for `dma_resv` and `drm_dev_{enter,exit}`,= and patches 4-6 use those new guards. The overall direction is good =E2=80= =94 guards eliminate entire classes of lock-leak bugs and the code becomes = more readable. The net diffstat (-712/+589) shows meaningful line reduction. The series ha= s prerequisite patches (a signal-from-irq series) which explains why it doe= sn't apply cleanly. I have a few concerns, primarily around patch 6's API signature change and = some subtle behavioral differences in the reclaim path (patch 1). Overall q= uality is high. --- Generated by Claude Code Patch Reviewer